[
https://issues.apache.org/jira/browse/PHOENIX-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897123#comment-17897123
]
ASF GitHub Bot commented on PHOENIX-7454:
-----------------------------------------
stoty commented on code in PR #169:
URL:
https://github.com/apache/phoenix-queryserver/pull/169#discussion_r1836133721
##########
phoenix-queryserver-client/pom.xml:
##########
@@ -50,11 +50,6 @@
<url>http://www.apache.org</url>
</organization>
- <properties>
- <top.dir>${project.basedir}/..</top.dir>
Review Comment:
We define top.dir everywhere.
I'm not sure if it is needed here or not, but it's outside the scope of this
ticket.
> Remove shaded.package property from phoenix-queryserver-client
> --------------------------------------------------------------
>
> Key: PHOENIX-7454
> URL: https://issues.apache.org/jira/browse/PHOENIX-7454
> Project: Phoenix
> Issue Type: Bug
> Components: queryserver
> Reporter: Istvan Toth
> Assignee: Szucs Villo
> Priority: Trivial
>
> We do not actually relocate anything, so it's misleading.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
