haridsv commented on code in PR #2033:
URL: https://github.com/apache/phoenix/pull/2033#discussion_r1877772933
##########
phoenix-core-client/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -1963,6 +1964,15 @@ public MutationState createCDC(CreateCDCStatement
statement) throws SQLException
ColumnResolver resolver =
FromCompiler.getResolver(NamedTableNode.create(statement.getDataTable()),
connection);
TableRef tableRef = resolver.getTables().get(0);
PTable dataTable = tableRef.getTable();
+ String
+ dataTableFullName =
+
SchemaUtil.getTableName(statement.getDataTable().getSchemaName(),
+ statement.getDataTable().getTableName());
+
+ // for now, only track stream partition metadata for tables, TODO:
updatable views
+ if (PTableType.TABLE.equals(dataTable.getType())) {
Review Comment:
nit: with enums you can do equality check
```suggestion
if (PTableType.TABLE == dataTable.getType()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
