virajjasani commented on code in PR #2033: URL: https://github.com/apache/phoenix/pull/2033#discussion_r1901259078
########## phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/tasks/CdcStreamPartitionMetadataTask.java: ########## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.phoenix.coprocessor.tasks; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HBaseConfiguration; +import org.apache.hadoop.hbase.HRegionLocation; +import org.apache.hadoop.hbase.client.RegionInfo; +import org.apache.phoenix.coprocessor.TaskRegionObserver; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.schema.PTable; +import org.apache.phoenix.schema.task.ServerTask; +import org.apache.phoenix.schema.task.SystemTaskParams; +import org.apache.phoenix.schema.task.Task; +import org.apache.phoenix.util.CDCUtil; +import org.apache.phoenix.util.QueryUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.sql.PreparedStatement; +import java.sql.SQLException; +import java.sql.Timestamp; +import java.util.List; + +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_CDC_STREAM_NAME; +import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_CDC_STREAM_STATUS_NAME; +import static org.apache.phoenix.query.QueryServices.PHOENIX_STREAMS_GET_TABLE_REGIONS_TIMEOUT; +import static org.apache.phoenix.query.QueryServicesOptions.DEFAULT_PHOENIX_STREAMS_GET_TABLE_REGIONS_TIMEOUT; + +/** + * Task to bootstrap partition metadata when CDC is enabled on a table. + * Upserts one row for each region of the table into SYSTEM.CDC_STREAM and marks the status as + * ENABLED in SYSTEM.CDC_STREAM_STATUS. + */ +public class CdcStreamPartitionMetadataTask extends BaseTask { + + public static final Logger LOGGER = LoggerFactory.getLogger(CdcStreamPartitionMetadataTask.class); + private static final String CDC_STREAM_STATUS_UPSERT_SQL + = "UPSERT INTO " + SYSTEM_CDC_STREAM_STATUS_NAME + " VALUES (?, ?, ?)"; + + // parent_partition_id will be null, set partition_end_time to -1 + private static final String CDC_STREAM_PARTITION_UPSERT_SQL + = "UPSERT INTO " + SYSTEM_CDC_STREAM_NAME + " VALUES (?,?,?,null,?,-1,?,?)"; + + @Override + public TaskRegionObserver.TaskResult run(Task.TaskRecord taskRecord) { + Configuration conf = HBaseConfiguration.create(env.getConfiguration()); + Configuration configuration = HBaseConfiguration.addHbaseResources(conf); + int getTableRegionsTimeout = configuration.getInt(PHOENIX_STREAMS_GET_TABLE_REGIONS_TIMEOUT, + DEFAULT_PHOENIX_STREAMS_GET_TABLE_REGIONS_TIMEOUT); + PhoenixConnection pconn = null; + String tableName = taskRecord.getTableName(); + String streamName = taskRecord.getSchemaName(); + Timestamp timestamp = taskRecord.getTimeStamp(); + try { + pconn = QueryUtil.getConnectionOnServer(env.getConfiguration()).unwrap(PhoenixConnection.class); + List<HRegionLocation> tableRegions = pconn.getQueryServices().getAllTableRegions( + tableName.getBytes(), getTableRegionsTimeout); Review Comment: We have seen issues with range scan queries timing out once or twice due to large num of regions. To handle them efficiently, precise region boundaries are now used: https://github.com/apache/phoenix/commit/0b9d8201875c27a8b8a1084680104057bcd46e60 However, even with large tables, CQSI#getTableRegions never timed out infinitely. It only used to timeout 1 or 2 times. This is because it never has to re-do the whole work, as every RPC call will be done only once for each region location. Once region location is retrieved, HBase client caches it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
