d-c-manning commented on code in PR #2061:
URL: https://github.com/apache/phoenix/pull/2061#discussion_r1933335940
##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java:
##########
@@ -156,9 +156,9 @@ public void testPhoenixMetricsLoggedOnClose() throws
Exception {
// Autocommit is turned off by default
// Hence mutation metrics are not expected during connection close
Review Comment:
this comment is still here though (are mutation metrics now expected during
connection close?
##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java:
##########
@@ -156,9 +156,9 @@ public void testPhoenixMetricsLoggedOnClose() throws
Exception {
// Autocommit is turned off by default
// Hence mutation metrics are not expected during connection close
Review Comment:
this line 157 comment is still here though (are mutation metrics now
expected during connection close?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
