tkhurana commented on code in PR #2077:
URL: https://github.com/apache/phoenix/pull/2077#discussion_r1996452243
##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java:
##########
@@ -955,12 +959,11 @@ private void assertMetricsHaveSameValues(Map<MetricType,
Long> metricNameValueMa
}
}
- private void changeInternalStateForTesting(PhoenixResultSet rs) throws
NoSuchFieldException,
- SecurityException, IllegalArgumentException,
IllegalAccessException {
+ private void changeInternalStateForTesting(PhoenixResultSet rs,
+ ReadMetricQueue
testMetricsQueue) throws
+ NoSuchFieldException, SecurityException, IllegalArgumentException,
Review Comment:
Maybe just change it to throws Exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]