tkhurana commented on code in PR #2077:
URL: https://github.com/apache/phoenix/pull/2077#discussion_r1996456413


##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java:
##########
@@ -1298,5 +1301,225 @@ public Connection call() throws Exception {
         }
     }
 
+    @Test
+    public void testPhoenixClientQueueWaitTimeAndEndToEndTime() throws 
SQLException,
+            NoSuchFieldException,
+            IllegalAccessException {
+        int saltBucketNum = 8;
+        String tableName = generateUniqueName();
+        String getRows = "SELECT COL1, COL2, PK4, PK2, PK3 FROM " + tableName
+                + " WHERE PK1=? AND PK2=? AND PK3=? AND PK4 IN (?";
+        // Send at least 4 tasks in Phoenix client thread pool and we will 
assert also on this
+        // later while actually querying data.
+        int taskCount = 4;
+        for (int i = 1; i < taskCount; i++) {
+            getRows += ", ?";
+        }
+        getRows += ")";
+        final String upsertRows = "UPSERT INTO " + tableName + " VALUES(?, ?, 
?, ?, ?, ?)";
+        String creatTableDdl = "CREATE TABLE IF NOT EXISTS " + tableName + " 
(\n" +

Review Comment:
   Generally we put the table schema first and then the upsert statements and 
the select statements. This makes it easy to understand the code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to