stoty commented on code in PR #188:
URL: https://github.com/apache/phoenix-omid/pull/188#discussion_r2028425630
##########
tso-server/bin/omid.sh:
##########
@@ -39,6 +46,12 @@ for j in ../lib/*.jar; do
CLASSPATH=$CLASSPATH:$j
done
+if [ -z ${OMID_OPTS+x} ]; then
Review Comment:
The problem is that both may have similar options, like -Xmx, in which case
it depends on the JVM version if the first or last one gets used.
That's why I want to make sure that HBASE_OPTS is a fallback to OMID_OPTS
rather than using both.
Phoenix currently adds both, but I also want to fix that one, because of the
possible conflicting options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
