jpisaac commented on code in PR #2075:
URL: https://github.com/apache/phoenix/pull/2075#discussion_r2006674296
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -1055,4 +1057,19 @@ public void
preClose(ObserverContext<RegionCoprocessorEnvironment> c, boolean ab
protected boolean isRegionObserverFor(Scan scan) {
return
scan.getAttribute(BaseScannerRegionObserverConstants.UNGROUPED_AGG) != null;
}
+
+ @Override
+ public void preBatchMutate(ObserverContext<RegionCoprocessorEnvironment> c,
+ MiniBatchOperationInProgress<Mutation>
miniBatchOp) throws IOException {
+ final Configuration conf = c.getEnvironment().getConfiguration();
+ try {
+ final HAGroupStoreManager haGroupStoreManager =
HAGroupStoreManager.getInstance(conf);
+ if(haGroupStoreManager.isMutationBlocked()) {
Review Comment:
nit: space after if
##########
phoenix-core-client/src/main/protobuf/RegionServerEndpointService.proto:
##########
@@ -50,10 +50,19 @@ message InvalidateServerMetadataCacheRequest {
repeated InvalidateServerMetadataCache invalidateServerMetadataCacheRequests
= 1;
}
+message InvalidateHAGroupStoreClientRequest {
+}
+
+message InvalidateHAGroupStoreClientResponse {
+}
+
service RegionServerEndpointService {
rpc validateLastDDLTimestamp(ValidateLastDDLTimestampRequest)
returns (ValidateLastDDLTimestampResponse);
rpc invalidateServerMetadataCache(InvalidateServerMetadataCacheRequest)
returns (InvalidateServerMetadataCacheResponse);
+
+ rpc InvalidateHAGroupStoreClient(InvalidateHAGroupStoreClientRequest)
Review Comment:
InvalidateHAGroupStoreClient should be with lowercase 'i' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
