ujjawal4046 commented on code in PR #2075:
URL: https://github.com/apache/phoenix/pull/2075#discussion_r2017893099
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -1055,4 +1057,20 @@ public void
preClose(ObserverContext<RegionCoprocessorEnvironment> c, boolean ab
protected boolean isRegionObserverFor(Scan scan) {
return
scan.getAttribute(BaseScannerRegionObserverConstants.UNGROUPED_AGG) != null;
}
+
+ @Override
+ public void preBatchMutate(ObserverContext<RegionCoprocessorEnvironment> c,
Review Comment:
> Mutations on Index tables need not be blocked since those need not be
replicated.
@jpisaac What do you mean by this ? The index mutations which are generated
for data tables would get replicated as well.
Since it's added for IndexRegionObserver as well, I am good with the change
since all coproc which have preBatchMutate are adding the logic to block
mutations. @ritegarg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
