lokiore commented on code in PR #2128:
URL: https://github.com/apache/phoenix/pull/2128#discussion_r2066988318
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HighAvailabilityPolicy.java:
##########
@@ -47,6 +48,23 @@ public Connection provide(HighAvailabilityGroup haGroup,
Properties info,
return new FailoverPhoenixConnection(context);
}
+ /**
+ * Cluster Role Transitions for Failover High Availability Policy,
Here we are trying to
+ * close connections late to allow existing reads to continue during
Failover.
+ * ACTIVE --> ACTIVE_TO_STANDBY (Doing Nothing as we are in process of
moving the current
Review Comment:
ACTIVE --> ACTIVE_TO_STANDBY is not doing anything here, as we just want to
block writes and nothing else, So if we go to ACTIVE_TO_STANDBY then rolling
back should be same (nothing required),
I see I missed commenting that will add the comment :v:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
