Copilot commented on code in PR #2133: URL: https://github.com/apache/phoenix/pull/2133#discussion_r2078311940
########## phoenix-core-server/src/main/java/org/apache/phoenix/replication/log/LogFileHeader.java: ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.replication.log; + +import java.io.DataInput; +import java.io.DataOutput; +import java.io.IOException; +import java.util.Arrays; + +import org.apache.hadoop.fs.FSDataInputStream; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.util.Bytes; + +public class LogFileHeader implements LogFile.Header { + + /** Magic number for Phoenix Replication Log files */ + static final byte[] MAGIC = Bytes.toBytes("PLOG"); + /** Current major version of the replication log format */ + static final int VERSION_MAJOR = 1; + /** Current minor version of the replication log format */ + static final int VERSION_MINOR = 0; + + static final int HEADERSIZE = MAGIC.length + 3 * Bytes.SIZEOF_BYTE; + + private int majorVersion = VERSION_MAJOR; + private int minorVersion = VERSION_MINOR; + + public LogFileHeader() { + + } + + @Override + public int getMajorVersion() { + return majorVersion; + } + + @Override + public LogFile.Header setMajorVersion(int majorVersion) { + this.majorVersion = majorVersion; + return this; + } + + @Override + public int getMinorVersion() { + return minorVersion; + } + + @Override + public LogFile.Header setMinorVersion(int minorVersion) { + this.minorVersion = minorVersion; + return this; + } + + @Override + public void readFields(DataInput in) throws IOException { + byte[] magic = new byte[MAGIC.length]; + in.readFully(magic); + if (!Arrays.equals(MAGIC, magic)) { + throw new IOException("Invalid LogFile magic. Got " + Bytes.toStringBinary(magic) + + ", expected " + Bytes.toStringBinary(MAGIC)); + } + majorVersion = in.readByte(); + minorVersion = in.readByte(); + // Basic version check for now + if (majorVersion != VERSION_MAJOR && minorVersion > VERSION_MINOR) { Review Comment: The version check condition using '&&' may not reliably detect mismatches. If the major version is different but the minor version is not greater than the expected, the check could pass erroneously. Consider revising the condition to use a logical OR for robust version validation. ```suggestion if (majorVersion != VERSION_MAJOR || minorVersion > VERSION_MINOR) { ``` ########## phoenix-core-server/src/main/java/org/apache/phoenix/replication/log/AsyncFSDataOutput.java: ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.replication.log; + +import java.io.IOException; +import java.io.InterruptedIOException; +import java.util.concurrent.ExecutionException; + +import org.apache.hadoop.hbase.io.asyncfs.AsyncFSOutput; +import org.apache.hadoop.hbase.util.Bytes; + +/** + * SyncableDataOutput implementation that delegates to a hbase-async AsyncFSOutput. + */ [email protected](value = { "EI_EXPOSE_REP", "EI_EXPOSE_REP2" }, + justification = "Intentional") +public class AsyncFSDataOutput implements SyncableDataOutput { + + private final AsyncFSOutput delegate; + + public AsyncFSDataOutput(AsyncFSOutput delegate) { + this.delegate = delegate; + } + + @Override + public long getPos() throws IOException { + return delegate.getSyncedLength() + delegate.buffered(); + } + + @Override + public void close() throws IOException { + delegate.close(); + } + + @Override + public void write(int b) throws IOException { + delegate.writeInt(b); Review Comment: In AsyncFSDataOutput, the write(int b) method writes an int (4 bytes) instead of a single byte as required by the DataOutput contract. Consider using writeByte(b) or writing a one-byte array with the proper cast to ensure only a single byte is written. ```suggestion byte[] singleByte = new byte[1]; singleByte[0] = (byte) b; delegate.write(singleByte); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
