lokiore commented on code in PR #2174:
URL: https://github.com/apache/phoenix/pull/2174#discussion_r2127355793
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HighAvailabilityPolicy.java:
##########
@@ -75,20 +75,20 @@ void transitClusterRole(HighAvailabilityGroup haGroup,
ClusterRoleRecord oldReco
"Doing nothing for Cluster Role Change");
return;
}
- if ((oldRecord.getRole1() == ACTIVE || oldRecord.getRole1() ==
ACTIVE_TO_STANDBY)
- && newRecord.getRole1() == STANDBY) {
- transitStandby(haGroup, oldRecord.getUrl1(),
oldRecord.getRegistryType());
+ if (oldRecord.getRole1() == ACTIVE &&
+ (newRecord.getRole1() == STANDBY || newRecord.getRole1()
== ACTIVE_TO_STANDBY)) {
Review Comment:
For Parallel we allow connection creation at any state except
OFFLINE/UNKNOWN. These state changes are only for Failover, for parallel we
don't do anything to connections when there is a state change. What usecase you
are thinking here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
