virajjasani commented on code in PR #2179:
URL: https://github.com/apache/phoenix/pull/2179#discussion_r2130722706
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/UpgradeUtil.java:
##########
@@ -1579,6 +1588,12 @@ public static void
moveHBaseLevelTTLToSYSCAT(PhoenixConnection oldMetaConnection
"in progress => numOfTableHasTTLMoved:
%d",
numOfTableThatHasTTLMoved));
+ } catch (SQLException e) {
+ LOGGER.error(String.format(
+ "Failed moving ttl value to TTL" +
+ " column for %s with Exception :",
+ currentTableName), e);
+
Review Comment:
Also, to log the error for any exception (e.g. NPE that we came across), how
about catching generic exception and logging the current table name?
```
} catch (Exception e) {
LOGGER.error("Failed moving ttl value to TTL"
+ " column for {} with Exception",
currentTableName, e);
throw new RuntimeException(e);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
