virajjasani commented on code in PR #2179:
URL: https://github.com/apache/phoenix/pull/2179#discussion_r2131180969
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/UpgradeUtil.java:
##########
@@ -1530,15 +1531,23 @@ public static void
moveHBaseLevelTTLToSYSCAT(PhoenixConnection oldMetaConnection
byte[] tableName =
rowKeyMetaData[PhoenixDatabaseMetaData.TABLE_NAME_INDEX];
String fullTableName =
SchemaUtil.getTableName(schemaName, tableName);
+ currentTableName = fullTableName;
if
(SchemaUtil.isSystemTable(SchemaUtil.getTableNameAsBytes(schemaName,
tableName))) {
//We do not support system table ttl through
phoenix ttl, and it will be moved to a
//constant value in future commit.
continue;
}
+ PTable pTable = oldMetaConnection.getTable(null,
fullTableName);
Review Comment:
I wonder if this could cause too many getTable() calls to syscat, though
should be manageable I assume. WDYT @jpisaac @tkhurana?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
