sanjeet006py commented on code in PR #2181:
URL: https://github.com/apache/phoenix/pull/2181#discussion_r2136023399
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:
##########
@@ -430,7 +430,8 @@ public void
preStoreScannerOpen(ObserverContext<RegionCoprocessorEnvironment> c,
Configuration conf = c.getEnvironment().getConfiguration();
if (isPhoenixCompactionEnabled(conf)) {
- setScanOptionsForFlushesAndCompactions(options);
+ options.setKeepDeletedCells(KeepDeletedCells.TTL);
+ options.setTTL(Long.MAX_VALUE);
Review Comment:
Using `store.getColumnFamilyDescriptor().getTimeToLive()` can cause Phoenix
row to expire partially as say one cell has HBase TTL expired but another cell
of same row but different column doesn't have TTL expired then from Phoenix
point of view all the cells should be visible. Please correct me if I am wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
