apurtell commented on code in PR #2200:
URL: https://github.com/apache/phoenix/pull/2200#discussion_r2162680226
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HighAvailabilityGroup.java:
##########
@@ -438,10 +438,21 @@ public static CuratorFramework getCurator(String jdbcUrl,
Properties properties)
try {
return CURATOR_CACHE.get(jdbcUrl, () -> {
CuratorFramework curator = createCurator(jdbcUrl, properties);
- if
(!curator.blockUntilConnected(PHOENIX_HA_ZK_CONNECTION_TIMEOUT_MS_DEFAULT,
- TimeUnit.MILLISECONDS))
- throw new RuntimeException("Failed to connect to the
CuratorFramework in "
- + "timeout " +
PHOENIX_HA_ZK_CONNECTION_TIMEOUT_MS_DEFAULT + " ms");
+ try {
Review Comment:
This is not applicable because the resource should not be closed if we
successfully connect. The instance will be cached and reused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
