virajjasani commented on PR #2199: URL: https://github.com/apache/phoenix/pull/2199#issuecomment-3001051883
This can work too, either we need too many if conditions, or we need new map with specific intention, which is more readable IMO. With too many if conditions, code review might look better for now but it's just increasing complexity. Whereas the new map will anyways be null, unless the client specifically asks for old row. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
