virajjasani commented on code in PR #2225:
URL: https://github.com/apache/phoenix/pull/2225#discussion_r2211813214
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/ScanUtil.java:
##########
@@ -1788,6 +1816,10 @@ public static void annotateMutationWithConditionalTTL(
byte[] ttl = ttlExpr.serialize();
for (Mutation mutation : mutations) {
mutation.setAttribute(BaseScannerRegionObserverConstants.TTL, ttl);
+ if (!table.isStrictTTL()) {
+
mutation.setAttribute(BaseScannerRegionObserverConstants.IS_STRICT_TTL,
+ PBoolean.INSTANCE.toBytes(table.isStrictTTL()));
+ }
Review Comment:
This is improvement: we don't need to send the mutation and scan attribute
`_IS_STRICT_TTL` if the TTL is already strict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
