ujjawal4046 commented on code in PR #2292:
URL: https://github.com/apache/phoenix/pull/2292#discussion_r2390325346
##########
phoenix-core-client/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java:
##########
@@ -361,12 +361,19 @@ private static void initializeScan(QueryPlan plan,
Integer perScanLimit, Integer
if (optimizeProjection) {
optimizeProjection(context, scan, table, statement);
}
+ if (context.hasRowSizeFunction()) {
+ scan.getFamilyMap().clear();
+ ScanUtil.removePageFilter(scan);
Review Comment:
I see the need to remove family map so that it accounts for cells across all
column families.
Why do we need to remove page filter ?
##########
phoenix-core-client/src/main/java/org/apache/phoenix/compile/QueryCompiler.java:
##########
@@ -752,6 +753,16 @@ protected QueryPlan compileSingleQuery(StatementContext
context, SelectStatement
protected QueryPlan compileSingleFlatQuery(StatementContext context,
SelectStatement select,
boolean asSubquery, boolean allowPageFilter, QueryPlan innerPlan, boolean
inJoin,
boolean inUnion) throws SQLException {
+ for (AliasedNode node : select.getSelect()) {
+ if (node.getNode() instanceof RowSizeParseNode) {
Review Comment:
I am not clear with the usage. Does it mean we can't use query where
row_size needs to be fetched for each row (e.g. `select row_size() from table`
or `select row_size() from table group by tenant_id`)
##########
phoenix-core-client/src/main/java/org/apache/phoenix/expression/function/RowSizeFunction.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.expression.function;
+
+import java.sql.SQLException;
+import java.util.List;
+import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
+import org.apache.phoenix.expression.Determinism;
+import org.apache.phoenix.expression.Expression;
+import org.apache.phoenix.parse.FunctionParseNode.BuiltInFunction;
+import org.apache.phoenix.parse.RowSizeParseNode;
+import org.apache.phoenix.schema.tuple.Tuple;
+import org.apache.phoenix.schema.types.*;
+
+/**
+ * Function to return the total size of the HBase cells that constitute a
given row
+ */
+@BuiltInFunction(name = RowSizeFunction.NAME, nodeClass =
RowSizeParseNode.class, args = {})
+public class RowSizeFunction extends ScalarFunction {
Review Comment:
Are the scalar function evaluated on server side as well (or only on client
side) ? If it's client side, then we need to fetch the whole row back to client
for size computation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
