virajjasani commented on code in PR #2297:
URL: https://github.com/apache/phoenix/pull/2297#discussion_r2415202176
##########
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/write/AbstractParallelWriterIndexCommitter.java:
##########
@@ -128,7 +149,6 @@ public void write(Multimap<HTableInterfaceReference,
Mutation> toWrite,
*/
Set<Entry<HTableInterfaceReference, Collection<Mutation>>> entries =
toWrite.asMap().entrySet();
- tasks = new TaskBatch<Void>(entries.size());
Review Comment:
`addTasks()` gives the same abstraction but having submitTasks() might make
it tricky to debug because writers already implement `write()`.
But let me enforce that child classes must implement write() by making
`write()` abstract
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
