ritegarg commented on code in PR #2302:
URL: https://github.com/apache/phoenix/pull/2302#discussion_r2437480050
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStateListener.java:
##########
@@ -43,15 +43,22 @@ public interface HAGroupStateListener {
* consider delegating to a separate thread.</p>
*
* @param haGroupName the name of the HA group that transitioned
+ * @param fromState the previous state before the transition
+ * can be null for initial state.
+ * Also, can be inaccurate in case there is
+ * connection loss to ZK and multiple state changes
happen in between.
Review Comment:
Yes, in case of connection loss there can be events which are missed.
Although this doesn't affect failover IMO, clients need to be aware of this
limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
