virajjasani commented on code in PR #2308:
URL: https://github.com/apache/phoenix/pull/2308#discussion_r2471953982
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/CDCUtil.java:
##########
@@ -89,7 +89,7 @@ public static String
makeChangeScopeStringFromEnums(Set<PTable.CDCChangeScope> i
}
public static String getCDCIndexName(String cdcName) {
- return CDC_INDEX_PREFIX + SchemaUtil.getTableNameFromFullName(cdcName);
+ return CDC_INDEX_PREFIX + cdcName;
Review Comment:
I just tried, it seems to be giving
`N000001.PHOENIX_CDC_INDEX_CDC_N000002.N000003` for table name
`N000001.N000002.N000003` and cdc object name `CDC_N000002.N000003`. But you
can also verify and then we are good to go.
I am still bit confused about this :)
How about we create this test?
```
CREATE TABLE TEST."test1.test2.table3" ("PK1" DOUBLE NOT NULL, "PK2" DOUBLE
NOT NULL, COL BSON CONSTRAINT pk PRIMARY KEY ("PK1","PK2"))
CREATE CDC "CDC_test1.test2.table3" on TEST."test1.test2.table3"
```
and then make sure the index created is
`TEST.PHOENIX_CDC_INDEX_test1.test2.table3` (not
`TEST.PHOENIX_CDC_INDEX_test2.table3`)? wdyt?
Or do we already have it and I missed it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
