haridsv commented on code in PR #2329:
URL: https://github.com/apache/phoenix/pull/2329#discussion_r2613330941
##########
phoenix-core-client/src/main/java/org/apache/phoenix/monitoring/MetricType.java:
##########
@@ -261,6 +261,18 @@ public enum MetricType {
COUNT_REMOTE_RPC_RETRIES("rrr", "Number of remote RPC retries",
LogLevel.DEBUG, PLong.INSTANCE),
COUNT_ROWS_SCANNED("ws", "Number of rows scanned", LogLevel.DEBUG,
PLong.INSTANCE),
COUNT_ROWS_FILTERED("wf", "Number of rows filtered", LogLevel.DEBUG,
PLong.INSTANCE),
+ FS_READ_TIME("frt", "Time spent in filesystem read", LogLevel.DEBUG,
PLong.INSTANCE),
+ BYTES_READ_FROM_FS("brff", "Number of bytes read from filesystem",
LogLevel.DEBUG,
+ PLong.INSTANCE),
+ BYTES_READ_FROM_MEMSTORE("brfm", "Number of bytes read from memstore",
LogLevel.DEBUG,
+ PLong.INSTANCE),
+ BYTES_READ_FROM_BLOCKCACHE("brfc", "Number of bytes read from blockcache",
LogLevel.DEBUG,
+ PLong.INSTANCE),
+ BLOCK_READ_OPS_COUNT("broc", "Number of block read operations",
LogLevel.DEBUG, PLong.INSTANCE),
+ RPC_SCAN_PROCESSING_TIME("rsp", "Time spent in RPC scan processing",
LogLevel.DEBUG,
+ PLong.INSTANCE),
+ RPC_SCAN_QUEUE_WAIT_TIME("rsqw", "Time spent in RPC scan queue wait",
LogLevel.DEBUG,
+ PLong.INSTANCE),
Review Comment:
Nit comment on the metric naming, I see an informal pattern of ending the
name with a "t" when it is related to time, so I wonder if it would be better
to name `rsp` as `rspt` (or just `spt`) and `rsqw` as `sqwt` (technically
`rsqwt`, but shorter names are preferable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
