haridsv commented on PR #2371:
URL: https://github.com/apache/phoenix/pull/2371#issuecomment-3882042787

   Most of checkstyle errors are also in existing lines. Only the below are in 
the changed lines:
   
   ```
   
./phoenix-core-client/src/main/java/org/apache/phoenix/execute/MutationState.java:2469:
            colValuesSizeDiff -= (entry.getKey().getEstimatedSize() + 
oldValue.length);:31: Unnecessary parentheses around assignment right-hand 
side. [UnnecessaryParentheses]
   
./phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServices.java:100:
  public static final String PRESERVE_MUTATIONS_ON_LIMIT_EXCEEDED_ATTRIB =:17: 
Redundant 'final' modifier. [RedundantModifier]
   ```
   
   The second one is following the existing pattern so I will leave it as is 
for consistency. I will fix the first one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to