rahulLiving commented on code in PR #2379:
URL: https://github.com/apache/phoenix/pull/2379#discussion_r2971155932
##########
phoenix-core-client/src/main/java/org/apache/phoenix/coprocessorclient/BaseScannerRegionObserverConstants.java:
##########
@@ -199,4 +199,23 @@ public static long getMaxLookbackInMillis(Configuration
conf) {
/** Exposed for testing */
public static final String SCANNER_OPENED_TRACE_INFO = "Scanner opened on
server";
+
+ /**
+ * PhoenixSyncTableTool scan attributes for server-side chunk formation and
checksum
+ */
+ public static final String SYNC_TABLE_CHUNK_FORMATION =
"_SyncTableChunkFormation";
Review Comment:
I have used SyncTableTool for user facing class/config. For others, I have
used SyncTable, are you recommending to move all Classes and config to SyncTool
instead of SyncTable i.e PhoenixSyncTableRegionScanner ->
PhoenixSyncToolRegionScanner ?
I felt SyncTable is more self explainable compared to SyncTool, we can also
change it to SyncTableTool at all places ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
