rahulLiving commented on code in PR #2379:
URL: https://github.com/apache/phoenix/pull/2379#discussion_r3056476336
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/ScanUtil.java:
##########
@@ -1207,8 +1207,9 @@ public static boolean isIndexRebuild(Scan scan) {
return
scan.getAttribute((BaseScannerRegionObserverConstants.REBUILD_INDEXES)) != null;
}
- public static boolean isSyncTableChunkFormation(Scan scan) {
- return
scan.getAttribute(BaseScannerRegionObserverConstants.SYNC_TABLE_CHUNK_FORMATION)
!= null;
+ public static boolean isSyncTableChunkFormationEnabled(Scan scan) {
+ return Arrays.equals(
+
scan.getAttribute(BaseScannerRegionObserverConstants.SYNC_TABLE_CHUNK_FORMATION),
TRUE_BYTES);
Review Comment:
While I believe that would be the right thing to do. But I see no scan
attribute follows a boolean naming convention. Do you think we should keep
naming as boolean variable for this specifically ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
