haridsv commented on code in PR #2419:
URL: https://github.com/apache/phoenix/pull/2419#discussion_r3138414443
##########
phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/PhoenixSyncTableOutputRepository.java:
##########
@@ -223,15 +225,15 @@ public List<PhoenixSyncTableCheckpointOutputRow>
getProcessedChunks(String table
ps.setString(paramIndex++, tenantId);
}
if (hasEndBoundary) {
- ps.setBytes(paramIndex++, mapperRegionEnd);
+ ps.setString(paramIndex++, bytesToHex(mapperRegionEnd));
}
if (hasStartBoundary) {
- ps.setBytes(paramIndex, mapperRegionStart);
+ ps.setString(paramIndex, bytesToHex(mapperRegionStart));
}
try (ResultSet rs = ps.executeQuery()) {
while (rs.next()) {
- byte[] rawStartKey = rs.getBytes("START_ROW_KEY");
- byte[] endRowKey = rs.getBytes("END_ROW_KEY");
+ byte[] rawStartKey = hexToBytes(rs.getString("START_ROW_KEY"));
+ byte[] endRowKey = hexToBytes(rs.getString("END_ROW_KEY"));
Review Comment:
Oh, you mean to preserve the order? Good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
