anmolnar commented on code in PR #2467:
URL: https://github.com/apache/phoenix/pull/2467#discussion_r3226486570
##########
bin/sqlline.py:
##########
@@ -94,6 +94,7 @@ def kill_child():
java_cmd = phoenix_utils.java + ' ' + phoenix_utils.jvm_module_flags + \
' ' + opts + \
+ ' ' + getattr(phoenix_utils, "zk_tls_args", "") + \
Review Comment:
No, we cannot. If it doesn't get any value in the utils, it will be
undefined and this code would throw an exception (tested).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
