kadirozde commented on code in PR #2474:
URL: https://github.com/apache/phoenix/pull/2474#discussion_r3242915646
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/PhoenixRegionServerEndpoint.java:
##########
@@ -79,6 +84,9 @@ public void start(CoprocessorEnvironment env) throws
IOException {
if (env instanceof RegionServerCoprocessorEnvironment) {
this.serverName = ((RegionServerCoprocessorEnvironment)
env).getServerName();
}
+ if (env instanceof HasRegionServerServices) {
Review Comment:
Is this check necessary? Are there cases where env is not an instance of
RegionServerCoprocessorEnvironment here or is this just defensive coding? Can
we add a comment here to clarify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
