tkhurana opened a new pull request, #2488: URL: https://github.com/apache/phoenix/pull/2488
## Summary The `ReplicationLog` constructor used to clamp the configured rotation size to the FileSystem default block size, so each log file fit in a single HDFS block (avoiding `addBlock` RPCs from the disruptor consumer). That clamp silently capped large rotation-size configs. This change decouples the two concerns: - Stop clamping rotation size to the FS default block size. - Create each log file with an explicit per-file block size via `FSDataOutputStreamBuilder` (`fs.createFile(path).overwrite(true).blockSize(N).build()`). - Block size comes from a new config `phoenix.replication.log.fs.block.size.bytes` (default 256 MB), plumbed through `LogFileWriterContext.fsBlockSize`. `LogFileTestUtil` gains a `stubCreateFile(...)` helper plus a typed `TestBuilder` subclass to avoid Mockito bridge-method ambiguity from the self-bounded generics on `FSDataOutputStreamBuilder.build()`. ## Test plan - [x] Existing `LogFileWriterSyncTest` passes with the new `fsBlockSize` plumbing - [ ] Verify rotation size > FS default block size is honored end-to-end - [ ] Verify each log file is created with the configured block size on HDFS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
