apurtell commented on code in PR #2461: URL: https://github.com/apache/phoenix/pull/2461#discussion_r3290033830
########## src/main/tla/ConsistentFailover/markdown/HAGroupStore.md: ########## @@ -0,0 +1,445 @@ +# HAGroupStore -- Peer-Reactive Transitions and Auto-Completion + +**Source:** [`HAGroupStore.tla`](../HAGroupStore.tla) + +## Overview + +`HAGroupStore` models the peer-reactive transitions and auto-completion actions of the Phoenix Consistent Failover protocol. These actions correspond to the `FailoverManagementListener` (`HAGroupStoreManager.java` L633-706), which reacts to peer ZK state changes via `PathChildrenCache` watchers, and the local auto-completion resolvers from `createLocalStateTransitions()` (L140-150). Review Comment: It is not. The spec doesn't necessarily model every implementation detail and may abstract a sequence of events as a single event, thus eliding details that way also. It's a trade off between representation fidelity and tractability.... a model checking of every single implementation detail would be computationally infeasible. That said, is there an essential property of HA_GROUP that may be missing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
