apurtell commented on code in PR #2492:
URL: https://github.com/apache/phoenix/pull/2492#discussion_r3352197925
##########
phoenix-core-server/src/main/java/org/apache/phoenix/replication/ReplicationLogGroup.java:
##########
@@ -1028,16 +1043,27 @@ private void updateModeOnFailure(IOException e) throws
IOException {
* @throws IOException if the sync operation fails
*/
private void processPendingSyncs(long sequence) throws IOException {
- if (pendingSyncFutures.isEmpty()) {
+ int pendingSyncCount = pendingSyncs.size();
+ if (pendingSyncCount == 0) {
return;
}
+ metrics.updatePendingSyncCount(pendingSyncCount);
+ // Record per-event wait between SYNC pickup and fsync start.
+ long syncStartNs = System.nanoTime();
Review Comment:
Move store to `syncStartNs` below the histogram updates to only time the
actual sync. Just a nit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
