Copilot commented on code in PR #2507:
URL: https://github.com/apache/phoenix/pull/2507#discussion_r3384045223
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseViewIT.java:
##########
@@ -219,11 +219,11 @@ protected Pair<String, Scan>
testUpdatableViewIndex(Integer saltBuckets, boolean
: " [0," + Short.MIN_VALUE + ",51] - [" + (saltBuckets - 1) + "," +
Short.MIN_VALUE
+ ",51]";
clientSortAlgo = saltBuckets == null ? null : "CLIENT MERGE SORT";
- serverFilterBy = null;
+ firstKeyOnlyProjection = false;
}
assertPlan(conn,
query).iteratorType(iteratorTypeAndScanSize).scanType("RANGE SCAN")
.table(expectedTableName).clientSortAlgo(clientSortAlgo).keyRanges(keyRanges)
- .serverWhereFilter(serverFilterBy);
+ .serverFirstKeyOnlyProjection(firstKeyOnlyProjection);
Review Comment:
In the non-local-index branch, the plan assertion only checks
`serverFirstKeyOnlyProjection` (false) but no longer asserts that
`serverEmptyColumnOnlyProjection` is also false. This weakens the test compared
to the previous `serverWhereFilter(null)` check and could let an unexpected
EMPTY COLUMN ONLY projection slip through undetected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
