apurtell opened a new pull request, #2525:
URL: https://github.com/apache/phoenix/pull/2525
Replace the `EXPLAIN [WITH REGIONS]` grammar with a comma-separated option
list `EXPLAIN [(<opt> [, <opt>]*)] <stmt>` accepting `REGIONS`, `VERBOSE`,
`FORMAT TEXT`, and `FORMAT JSON`, preserving `EXPLAIN WITH REGIONS` as a
backward compatible alias.
`VERBOSE`, `FORMAT`, `TEXT`, and `JSON` are matched as `identifier` inside
`explain_node` and validated against a closed set in the action block. Update
`PhoenixSQL.g` `explain_node` rule to accept either `LPAREN id (COMMA id)*
RPAREN` or `WITH REGIONS` between `EXPLAIN` and the inner `oneStatement`, with
`FORMAT TEXT|JSON` parsed as `FORMAT` followed by an identifier.
`ExplainStatement` replaces `ExplainType` with `ExplainOptions { boolean
regions; boolean verbose; Format format; }`. `ParseNodeFactory` gains a
`factory.explain(stmt, ExplainOptions)` overload.
`PhoenixStatement#ExecutableExplainStatement` takes `ExplainOptions` and
propagates `regions` through to `BaseResultIterators.explainUtil`.
Region locator lookup still happens unconditionally.
Co-authored-by: Claude Opus 4.8[1m] <[email protected]>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
