apurtell opened a new pull request, #2528: URL: https://github.com/apache/phoenix/pull/2528
Remove unused bookkeeping from `StatementContext`. Drops `unionTags`, `addLiftedHavingNode()`, `isLiftedHavingNode()` and the backing `liftedHavingNodes` set (the HAVING-lift breadcrumb is still emitted as a `REWRITE HAVING PREDICATE AS WHERE` line via `appliedRewrites`), and `addIndexExpressionSubstitution()` / `getIndexExpressionSubstitutions()` and the backing `indexExpressionSubstitutions` list. Removes the corresponding fields, their entries in the copy constructor, the no-arg-init constructor, and `adoptRewriteState`, plus the now-dead `breadcrumbContext.addIndexExpressionSubstitution()` call in `IndexExpressionParseNodeRewriter` and the `addLiftedHavingNode` loop in `HavingCompiler`. No behavior change. EXPLAIN text and JSON output are unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
