virajjasani commented on code in PR #9:
URL: https://github.com/apache/phoenix-adapters/pull/9#discussion_r3456088780
##########
phoenix-ddb-rest/src/main/java/org/apache/phoenix/ddb/service/utils/DQLUtils.java:
##########
@@ -186,7 +186,12 @@ public static void addFilterCondition(boolean isQuery,
StringBuilder queryBuilde
* Set the given AttributeValue on the PreparedStatement at the given
index based on type.
*/
public static void setKeyValueOnStatement(PreparedStatement stmt, int
index,
- Map<String, Object> attrVal, boolean isBeginsWith) throws
SQLException {
+ Map<String, Object> attrVal, String placeholderName, boolean
isBeginsWith) throws SQLException {
+ if (attrVal == null) {
+ throw new ValidationException(
+ "Value provided in ExpressionAttributeValues unused in
expressions: keys: {"
+ + placeholderName + "}");
+ }
Review Comment:
To keep the changes simpler, let's not even use `placeholderName` in
exception message so that method signature remains same and all service
implementations don't need to change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
