ritegarg commented on code in PR #2576:
URL: https://github.com/apache/phoenix/pull/2576#discussion_r3643352603
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreClient.java:
##########
@@ -795,6 +804,7 @@ private void updateSystemTableHAGroupRecordSilently(String
haGroupName,
pstmt.executeUpdate();
conn.commit();
} catch (Exception e) {
+ metricsSource.incrementSystemTableSyncFailedCount();
Review Comment:
Addressed in 64a625c417. The metric now covers the complete synchronization
attempt: failures while preparing or writing SYSTEM.HA_GROUP are counted in the
helper, while periodic failures before the write are counted by the outer sync
handler. The paths are mutually exclusive, so each failed attempt increments
once.
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreClient.java:
##########
Review Comment:
Addressed in 64a625c417. Both synchronization error logs now pass the
exception as the trailing SLF4J argument, so the full stack trace and root
cause are preserved.
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreClient.java:
##########
Review Comment:
Addressed in 64a625c417. Periodic synchronization now catches and counts ZK
reads, peer reads, policy/URL preparation, system-table comparison, and write
failures. Write-helper failures are swallowed after counting and return false,
preventing double-counting and false success logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
