tkhurana commented on code in PR #2574:
URL: https://github.com/apache/phoenix/pull/2574#discussion_r3707704134
##########
phoenix-core-client/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1528,6 +1528,10 @@ private void sendMutations(Iterator<Entry<TableInfo,
List<Mutation>>> mutationsI
// no-op if table doesn't have Conditional TTL
ScanUtil.annotateMutationWithConditionalTTL(connection,
tableInfo.getPTable(),
mutationList);
+ // no-op unless table/view has a literal TTL; threads the empty-column
CF/CQ (plus a view's
+ // literal TTL and any non-strict flag) so the internal current-row
scan masks like a client
+ // read
+ ScanUtil.annotateMutationWithLiteralTTL(connection,
tableInfo.getPTable(), mutationList);
Review Comment:
Did you verify that conditional ttl doesn't have this problem ? I didn't see
any test cases with conditional ttl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
