tkhurana commented on code in PR #2614:
URL: https://github.com/apache/phoenix/pull/2614#discussion_r3952641263
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/CompactionScanner.java:
##########
@@ -1156,10 +1156,15 @@ public NonPartitionedTableTTLTracker(PhoenixConnection
pConn, PTable pTable, Sto
throws IOException {
boolean isSystemTable = pTable.getType() == PTableType.SYSTEM;
+ // A SYSTEM table with a CONDITIONAL TTL (e.g. SYSTEM.CDC_STREAM) must
NOT be forced onto the
+ // column-family descriptor TTL (which is FOREVER for such tables); its
conditional expression
+ // has to be compiled so that expired rows are physically purged at
major compaction, not
+ // merely masked at read time.
+ boolean isConditionalTTL = pTable.getTTLExpression() instanceof
ConditionalTTLExpression;
Review Comment:
Simpler API pTable.hasConditionalTTL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
