tkhurana opened a new pull request, #2620: URL: https://github.com/apache/phoenix/pull/2620
The time-based rotation tick and size/fault rotations shared one rotationRequested CAS gate, so a scheduled boundary tick firing while an on-demand rotation held the gate could be coalesced away, leaving a round boundary without its own .plog file.Make coalescing asymmetric in requestRotation(boolean): on-demand callers still CAS the gate (coalescing into any in-flight rotation, including a scheduled one), while the scheduled tick force-holds the gate with set(true) and always enqueues, so a boundary is never coalesced away. No new synchronization state; LogRotationTask still clears the gate in its finally.Adds testScheduledTickNotCoalescedWhenGateHeld and testOnDemandCoalescesIntoScheduledRotation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
