xavifeds8 opened a new pull request, #2626:
URL: https://github.com/apache/phoenix/pull/2626
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://phoenix.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
PHOENIX-XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes, and
prefix it with the JIRA id, e.g. 'PHOENIX-XXXX Your PR title ...'.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Guard the cross-RPC offset row-count recovery in
NonAggregateRegionScannerFactory.getOffsetScanner() against a null
SCAN_ACTUAL_START_ROW scan attribute. A single null check
(prevScanStartRowKey != null) is added before the two
Bytes.compareTo(...) calls, one of which passes the value into
ByteUtil.concat(...). A regression test,
QueryWithOffsetIT.testPointLookupWithOffset, is added.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
A point-lookup query (equality on the full primary key) combined with an
OFFSET clause crashes on the first scan RPC with a NullPointerException thrown
from ByteUtil.concat(prevScanStartRowKey, ByteUtil.ZERO_BYTE). The recovery
logic introduced by PHOENIX-7106 assumes the SCAN_ACTUAL_START_ROW attribute is
always populated, but the point-lookup fast path in BaseResultIterators never
sets it — only scans routed through ScanRanges.intersectScan() or
ScanUtil.setLocalIndexAttributes() do. The attribute is therefore null on the
first (and only) RPC, and affects any OFFSET value, including OFFSET 0, and is
independent of column encoding and HBase version.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Phoenix versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes a bug fix. Point-lookup queries with an OFFSET clause now execute and
return correct results instead of failing with a server-side
NullPointerException.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Added QueryWithOffsetIT.testPointLookupWithOffset, which exercises a full-PK
point lookup with OFFSET 0, a skipping
non-zero OFFSET, and the reverse-scan variant. The test is parameterized
over the existing SPLIT and SALT_BUCKETS table layouts; under the SPLIT
(non-salted, multi-region) layout it reproduces the NPE without the fix and
passes with it. (IT
run result to be inserted below once confirmed.) Manually verified on a
live HBase 2.6.4 cluster with a server jar built from this branch: SELECT *
FROM users WHERE id = 5 LIMIT 5 OFFSET 0; returns the matching row instead of
crashing.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
