jinggou opened a new pull request, #2637:
URL: https://github.com/apache/phoenix/pull/2637
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://phoenix.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
PHOENIX-XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes, and
prefix it with the JIRA id, e.g. 'PHOENIX-XXXX Your PR title ...'.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Move pushed LIMIT enforcement into UncoveredGlobalIndexRegionScanner, after
index entries are verified against their base rows.
Remove PageFilter and reopen the underlying scanner before scanning. Count
only valid, nonempty, nondummy results toward the limit. Preserve the existing
INDEX_LIMIT batching path.
Add regression tests in UncoveredGlobalIndexLimitIT and the existing
UncoveredGlobalIndexRegionScannerIT. This patch is independent of PHOENIX-8016.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
PHOENIX-8015: stale index entries can consume the pushed row limit before
uncovered-index verification rejects them. Queries therefore return fewer rows
than requested despite valid rows being available.
For example, three leading stale entries cause LIMIT 5 to return only two
valid rows. If all five candidates are stale, the query returns zero.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Phoenix versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Queries using uncovered global indexes now continue past stale entries
until they return the requested number of valid rows or exhaust the scan. This
also corrects affected LIMIT queries with OFFSET.
SQL syntax is unchanged.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
- All eight tests in UncoveredGlobalIndexLimitIT passed, covering stale
prefixes, multiple batches, dummy paging, TTL configurations, OFFSET,
insufficient available rows, workaround controls, and server-result counts.
- The expanded UncoveredGlobalIndexRegionScannerIT passed all 56
parameterized cases, including six expected covered-index skips. New
regressions cover salted and unsalted uncovered indexes.
- Plain LIMIT and OFFSET regressions failed against the original scanner and
passed with the fix. Finite-TTL cases already passed on this checkout and
remain controls.
- Disabling the new server counter while retaining filter removal caused the
server-count assertion to fail: expected five rows, received twenty.
- Tests verified that young stale entries remain physically present,
demonstrating correctness without relying on cleanup.
Compilation, Spotless, and whitespace checks passed.
- Integration tests ran through JUnitCore using local HBase mini-clusters,
with explicit current-reactor classpaths and verification of the loaded scanner
source.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Co-authored using OpenAI Codex (GPT-6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
