dimas-b commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1852668537
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -181,6 +196,19 @@ private PrincipalSecretsResult
bootstrapServiceAndCreatePolarisPrincipalForRealm
throw new IllegalArgumentException(overrideMessage);
}
+ // TODO rebase onto #422, call a method like
PrincipalSecretsGenerator.hasEnvironmentVariables
Review Comment:
idea: maybe pass a flag down to `PrincipalSecretsGenerator` to _not_ use
random secrets if `printCredentials` is `false`? Then the
`PrincipalSecretsGenerator` can simply throw if the specific realm/user
combination is missing env. vars. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
