dimas-b commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1852669846
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -181,6 +196,19 @@ private PrincipalSecretsResult
bootstrapServiceAndCreatePolarisPrincipalForRealm
throw new IllegalArgumentException(overrideMessage);
}
+ // TODO rebase onto #422, call a method like
PrincipalSecretsGenerator.hasEnvironmentVariables
+ boolean environmentVariableCredentials = false;
+ if (!this.printCredentials(polarisContext) &&
!environmentVariableCredentials) {
+ String failureMessage =
+ String.format(
+ "It appears that environment variables were not provided for
root credentials, and that printing "
+ + "the root credentials is disabled via %s. If bootstrapping
were to proceed, there would be no way "
+ + "to recover the root credentials",
+ PolarisConfiguration.BOOTSTRAP_PRINT_CREDENTIALS.key);
+ LOGGER.error("\n\n {} \n\n", failureMessage);
+ throw new IllegalArgumentException(failureMessage);
Review Comment:
Good idea :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
