dimas-b commented on code in PR #499:
URL: https://github.com/apache/polaris/pull/499#discussion_r1863676631
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/CoreAuthorizer.java:
##########
@@ -119,8 +122,8 @@
* the expanded roles of the calling Principal hold SERVICE_MANAGE_ACCESS on
the "root" catalog,
* which translates into a cross-catalog permission.
*/
-public class PolarisAuthorizerImpl implements PolarisAuthorizer {
- private static final Logger LOGGER =
LoggerFactory.getLogger(PolarisAuthorizerImpl.class);
+public class CoreAuthorizer implements PolarisAuthorizer {
Review Comment:
Rename suggestion SGTM.
Not sure about moving to `polaris-service`... I was, indeed, contemplating
that at some point, but later changed my mind because the logic in this class
is pretty fundamental to how Apache Polaris handles permissions. This class
works based on the pre-built manifest, but it is not affected by differences in
the communication protocols and backend storage (which is specific to
`polaris-service`, I guess)... but I'm fine moving if you (or others) prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
