dimas-b commented on code in PR #499: URL: https://github.com/apache/polaris/pull/499#discussion_r1863684106
########## polaris-core/src/main/java/org/apache/polaris/core/auth/AllowAllAuthorizer.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.auth; + +import jakarta.annotation.Nonnull; +import java.util.List; +import org.apache.polaris.core.PolarisConfigurationStore; +import org.apache.polaris.core.persistence.resolver.PolarisResolutionManifest; + +public class AllowAllAuthorizer implements PolarisAuthorizer { Review Comment: Unfortunately, the original `PolarisAuthorizer` impl. takes a constructor argument. I do not think DW is able to handle that. With CDI (e.g. HK2) we should be able to do that, but for now I think we have to use a no-arg factory injected into the config and then create an authorizer instance from the factory. This will add some boiler-plate code, which is why I did the manual constructor invocation in the first revision of this PR... but I'm fine updating to more DW-native injection patterns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
