adutra commented on code in PR #631:
URL: https://github.com/apache/polaris/pull/631#discussion_r1909064213
##########
dropwizard/service/src/test/java/org/apache/polaris/service/dropwizard/PolarisApplicationIntegrationTest.java:
##########
@@ -722,7 +722,7 @@ public void testRequestBodyTooLarge() {
.header(REALM_PROPERTY_KEY, realm)
.post(largeRequest)) {
assertThat(response)
- .returns(Response.Status.BAD_REQUEST.getStatusCode(),
Response::getStatus)
+ .returns(Response.Status.REQUEST_ENTITY_TOO_LARGE.getStatusCode(),
Response::getStatus)
Review Comment:
> on the client side the connection can be closed only after the status line
is received
Where is that specified? I find it hard to enforce such a guarantee. If the
server closes the connection, I don't think there is a way for the TCP layer to
close the connection gracefully only after some TCP message containing the
status is received by the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
