dimas-b commented on code in PR #631:
URL: https://github.com/apache/polaris/pull/631#discussion_r1909139561
##########
dropwizard/service/src/test/java/org/apache/polaris/service/dropwizard/PolarisApplicationIntegrationTest.java:
##########
@@ -722,7 +722,7 @@ public void testRequestBodyTooLarge() {
.header(REALM_PROPERTY_KEY, realm)
.post(largeRequest)) {
assertThat(response)
- .returns(Response.Status.BAD_REQUEST.getStatusCode(),
Response::getStatus)
+ .returns(Response.Status.REQUEST_ENTITY_TOO_LARGE.getStatusCode(),
Response::getStatus)
Review Comment:
What an interesting :) mess, TIL... In this case, I'd say we should drop
both the body and header size tests, because it's way beyond the scope of
Polaris to ensure deterministic behaviours of these tests.
I personally do not see much value in a test that _either_ validates the
status code or does not validate anything because a connection close exception
is inconclusive and does not guarantee that even the request was sent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
