snazy commented on code in PR #812: URL: https://github.com/apache/polaris/pull/812#discussion_r1919627847
########## regtests/client/python/pyproject.toml: ########## @@ -21,11 +21,11 @@ name = "polaris" Review Comment: Wonder, I see that this parameter is deprecated in favor of `project.name`. Is it worth to adopt? ########## regtests/client/python/pyproject.toml: ########## @@ -21,11 +21,11 @@ name = "polaris" version = "1.0.0" description = "Polaris Management Service" Review Comment: ```suggestion description = "Apache Polaris Management Service" ``` ########## regtests/client/python/pyproject.toml: ########## @@ -21,11 +21,11 @@ name = "polaris" version = "1.0.0" description = "Polaris Management Service" -authors = ["OpenAPI Generator Community <[email protected]>"] -license = "NoLicense" +authors = ["Apache Software Foundation <[email protected]>"] +license = "Apache License 2.0" readme = "README.md" -repository = "https://github.com/GIT_USER_ID/GIT_REPO_ID"; -keywords = ["OpenAPI", "OpenAPI-Generator", "Polaris Management Service"] +repository = "https://github.com/apache/polaris/"; +keywords = ["Iceberg", "Polaris Management Service"] Review Comment: Maybe add "Polaris" as a separate keyword. Not sure how these keywords actually work and how those are indexed and searched. ########## regtests/client/python/pyproject.toml: ########## @@ -21,11 +21,11 @@ name = "polaris" version = "1.0.0" description = "Polaris Management Service" -authors = ["OpenAPI Generator Community <[email protected]>"] -license = "NoLicense" +authors = ["Apache Software Foundation <[email protected]>"] +license = "Apache License 2.0" readme = "README.md" -repository = "https://github.com/GIT_USER_ID/GIT_REPO_ID"; -keywords = ["OpenAPI", "OpenAPI-Generator", "Polaris Management Service"] +repository = "https://github.com/apache/polaris/"; +keywords = ["Iceberg", "Polaris Management Service"] Review Comment: Not sure whether "Iceberg" is correct for the client, but I don't mind keeping it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
