MonkeyCanCode commented on code in PR #812:
URL: https://github.com/apache/polaris/pull/812#discussion_r1919654342


##########
regtests/client/python/pyproject.toml:
##########
@@ -21,11 +21,11 @@
 name = "polaris"

Review Comment:
   This is I am not sure, but I can look into later this week.
   
   From official doc, I am not seeing obvious messages for deprecation (nor 
from running the test locally):
   ```
   Poetry assumes your package contains a package with the same name as 
project.name located in the root of your project. If this is not the case, 
populate 
[tool.poetry.packages](https://python-poetry.org/docs/pyproject/#packages) to 
specify your packages and their locations.
   ```
   
   Then looking at pyiceberg, they are doing similar layout as well: 
https://github.com/apache/iceberg-python/blob/main/pyproject.toml



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to